-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Regenerate CRD Integration Test testdata #593
Conversation
Welcome @erikgb! |
@mengqiy @pwittrock Would it make sense to split this PR? One for generating the missing help message (🐛) and one for re-generating the test resources (🌱)? And do you require an issue for each PR? |
I think so, and created #597 for the bugfix. |
/assign @mengqiy Any chance to have a review on this? It is "just" a re-generation of what appears to be outdated files - and no "real" changes - just YAML reformatting. This is kinda blocking any progress on my functional PR.... |
Hi @erikgb, So, the testdata has not been checked if is updated for each PR? |
@camilamacedo86 Thx for taking a look at this old PR!
No, it seems like some PRs have been merged without update to the testdata.
I totally agree! I will try to update this PR with a GHA-job that verifies that the generated code is up to date. Will ping you for a new review when that is done. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am considering submitting a functional PR, and had a look in the codebase - to get a bit familiar. Since I am probably going to suggest a new CRD marker, I took special note on the process for generating testdata.
And it seems like the "golden output file" hasn't been re-generated lately. At least I get a big diff related to newlines in the desciption fields. Possibly related issue: #514.